From 0549ebea223beeb68c09ac9656579f02e893c0f7 Mon Sep 17 00:00:00 2001 From: Xavier Noria Date: Sat, 11 May 2013 01:28:06 +0200 Subject: Revert "Don't try to EXPLAIN select_db calls" Reason: This was backported, but the test does not pass as is. This reverts commit a33d320cf4b57fabd9c299b09c217ee3955ecc77. --- activerecord/lib/active_record/explain_subscriber.rb | 2 +- activerecord/test/cases/explain_subscriber_test.rb | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) (limited to 'activerecord') diff --git a/activerecord/lib/active_record/explain_subscriber.rb b/activerecord/lib/active_record/explain_subscriber.rb index 1d861a57db..859c8edfc5 100644 --- a/activerecord/lib/active_record/explain_subscriber.rb +++ b/activerecord/lib/active_record/explain_subscriber.rb @@ -15,7 +15,7 @@ module ActiveRecord # On the other hand, we want to monitor the performance of our real database # queries, not the performance of the access to the query cache. IGNORED_PAYLOADS = %w(SCHEMA EXPLAIN CACHE) - EXPLAINED_SQLS = /\A\s*(select|update|delete|insert)\b/i + EXPLAINED_SQLS = /\A\s*(select|update|delete|insert)/i def ignore_payload?(payload) payload[:exception] || IGNORED_PAYLOADS.include?(payload[:name]) || payload[:sql] !~ EXPLAINED_SQLS end diff --git a/activerecord/test/cases/explain_subscriber_test.rb b/activerecord/test/cases/explain_subscriber_test.rb index f929ddd79e..7b852a625d 100644 --- a/activerecord/test/cases/explain_subscriber_test.rb +++ b/activerecord/test/cases/explain_subscriber_test.rb @@ -38,13 +38,6 @@ if ActiveRecord::Base.connection.supports_explain? end end - def test_collects_nothing_if_the_statement_is_only_partially_matched - with_queries([]) do |queries| - SUBSCRIBER.finish(:name => 'SQL', :sql => 'select_db yo_mama') - assert queries.empty? - end - end - def test_collects_nothing_if_unexplained_sqls with_queries([]) do |queries| SUBSCRIBER.call(:name => 'SQL', :sql => 'SHOW max_identifier_length') -- cgit v1.2.3