From dddbccb25a709e1897326e2a25d37da83bbfd717 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rafael=20Mendon=C3=A7a=20Fran=C3=A7a?=
 <rafaelmfranca@gmail.com>
Date: Mon, 9 Jun 2014 17:25:20 -0300
Subject: Timestamp values should be present on callbacks

This reverts commit dd3ea17191e316aeebddaa7b176f6cfeee7a6365 and add a
regression test.

Fixes #15418
---
 activerecord/test/cases/timestamp_test.rb | 31 +++++++++++++------------------
 activerecord/test/schema/schema.rb        |  1 +
 2 files changed, 14 insertions(+), 18 deletions(-)

(limited to 'activerecord/test')

diff --git a/activerecord/test/cases/timestamp_test.rb b/activerecord/test/cases/timestamp_test.rb
index 77ab427be0..0472246f71 100644
--- a/activerecord/test/cases/timestamp_test.rb
+++ b/activerecord/test/cases/timestamp_test.rb
@@ -71,24 +71,6 @@ class TimestampTest < ActiveRecord::TestCase
     assert_equal @previously_updated_at, @developer.updated_at
   end
 
-  def test_saving_when_callback_sets_record_timestamps_to_false_doesnt_update_its_timestamp
-    klass = Class.new(Developer) do
-      before_update :cancel_record_timestamps
-      def cancel_record_timestamps
-        self.record_timestamps = false
-        return true
-      end
-    end
-
-    developer = klass.first
-    previously_updated_at = developer.updated_at
-
-    developer.name = "New Name"
-    developer.save!
-
-    assert_equal previously_updated_at, developer.updated_at
-  end
-
   def test_touching_an_attribute_updates_timestamp
     previously_created_at = @developer.created_at
     @developer.touch(:created_at)
@@ -399,6 +381,19 @@ class TimestampTest < ActiveRecord::TestCase
     assert_not_equal time, pet.updated_at
   end
 
+  def test_timestamp_column_values_are_present_in_the_callbacks
+    klass = Class.new(ActiveRecord::Base) do
+      self.table_name = 'people'
+
+      before_create do
+        self.born_at = self.created_at
+      end
+    end
+
+    person = klass.create first_name: 'David'
+    assert_not_equal person.born_at, nil
+  end
+
   def test_timestamp_attributes_for_create
     toy = Toy.first
     assert_equal [:created_at, :created_on], toy.send(:timestamp_attributes_for_create)
diff --git a/activerecord/test/schema/schema.rb b/activerecord/test/schema/schema.rb
index 5f459cf682..98fd0b6803 100644
--- a/activerecord/test/schema/schema.rb
+++ b/activerecord/test/schema/schema.rb
@@ -529,6 +529,7 @@ ActiveRecord::Schema.define do
     t.references :best_friend
     t.references :best_friend_of
     t.integer    :insures, null: false, default: 0
+    t.timestamp :born_at
     t.timestamps
   end
 
-- 
cgit v1.2.3