From 7a09fc55c0d89f6a672c79fdd9787c51a85a06fc Mon Sep 17 00:00:00 2001 From: Sean Griffin Date: Sat, 10 Jan 2015 12:24:10 -0700 Subject: Stop special casing null binary data in logging There's very little value in logging "" instead of just "nil". I'd like to remove the column from the equation entirely, and this case is preventing us from doing so. --- activerecord/test/cases/log_subscriber_test.rb | 7 ------- 1 file changed, 7 deletions(-) (limited to 'activerecord/test') diff --git a/activerecord/test/cases/log_subscriber_test.rb b/activerecord/test/cases/log_subscriber_test.rb index a578e81844..97c0350911 100644 --- a/activerecord/test/cases/log_subscriber_test.rb +++ b/activerecord/test/cases/log_subscriber_test.rb @@ -125,12 +125,5 @@ class LogSubscriberTest < ActiveRecord::TestCase wait assert_match(/<16 bytes of binary data>/, @logger.logged(:debug).join) end - - def test_nil_binary_data_is_logged - binary = Binary.create(data: "") - binary.update_attributes(data: nil) - wait - assert_match(//, @logger.logged(:debug).join) - end end end -- cgit v1.2.3