From ec6dfdc8d21031e07dd381853ff37fcc63f8bd86 Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Thu, 2 May 2019 21:42:56 +0900 Subject: Fix eager loading associations with string joins not to raise NoMethodError Fixes #34456. --- activerecord/test/models/rating.rb | 1 + 1 file changed, 1 insertion(+) (limited to 'activerecord/test/models') diff --git a/activerecord/test/models/rating.rb b/activerecord/test/models/rating.rb index 49aa38285f..2a18ea45ac 100644 --- a/activerecord/test/models/rating.rb +++ b/activerecord/test/models/rating.rb @@ -4,4 +4,5 @@ class Rating < ActiveRecord::Base belongs_to :comment has_many :taggings, as: :taggable has_many :taggings_without_tag, -> { left_joins(:tag).where("tags.id": nil) }, as: :taggable, class_name: "Tagging" + has_many :taggings_with_no_tag, -> { joins("LEFT OUTER JOIN tags ON tags.id = taggings.tag_id").where("tags.id": nil) }, as: :taggable, class_name: "Tagging" end -- cgit v1.2.3