From ce40073c9c321575e6b4f46dd5ac9b796a2637be Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Wed, 24 Oct 2018 10:31:41 +0900 Subject: Lazy checking whether or not values in IN clause are boundable Since #33844, eager loading/preloading with too many and/or too large ids won't be broken by pre-checking whether the value is constructable or not. But the pre-checking caused the type to be evaluated at relation build time instead of at the query execution time, that is breaking an expectation for some apps. I've made the pre-cheking lazy as much as possible, that is no longer happend at relation build time. --- activerecord/test/fixtures/citations.yml | 1 + 1 file changed, 1 insertion(+) (limited to 'activerecord/test/fixtures') diff --git a/activerecord/test/fixtures/citations.yml b/activerecord/test/fixtures/citations.yml index d31cb8efa1..396099621c 100644 --- a/activerecord/test/fixtures/citations.yml +++ b/activerecord/test/fixtures/citations.yml @@ -1,4 +1,5 @@ <% 65536.times do |i| %> fixture_no_<%= i %>: id: <%= i %> + book2_id: <%= i*i %> <% end %> -- cgit v1.2.3