From 828d0d7a7751a0c6a9faf0c96b89b0ea06a76094 Mon Sep 17 00:00:00 2001 From: Diego Carrion Date: Sat, 13 Jun 2015 12:51:32 -0300 Subject: thrown ActiveRecord::AssociationTypeMismatch when assigning a wrong value for a namespaced association fixes #20541 --- .../cases/associations/belongs_to_associations_test.rb | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'activerecord/test/cases') diff --git a/activerecord/test/cases/associations/belongs_to_associations_test.rb b/activerecord/test/cases/associations/belongs_to_associations_test.rb index 039cc46b0b..7726829be4 100644 --- a/activerecord/test/cases/associations/belongs_to_associations_test.rb +++ b/activerecord/test/cases/associations/belongs_to_associations_test.rb @@ -19,6 +19,8 @@ require 'models/invoice' require 'models/line_item' require 'models/column' require 'models/record' +require 'models/admin' +require 'models/admin/user' class BelongsToAssociationsTest < ActiveRecord::TestCase fixtures :accounts, :companies, :developers, :projects, :topics, @@ -151,6 +153,22 @@ class BelongsToAssociationsTest < ActiveRecord::TestCase assert_raise(ActiveRecord::AssociationTypeMismatch) { Account.find(1).firm = Project.find(1) } end + def test_type_mismatch_with_namespaced_class + assert_nil defined?(Region), "This test should be done with a only namespaced class" + ActiveRecord::Base.connection.create_table(:admin_regions) { |t| t.string :name } + ActiveRecord::Base.connection.add_column :admin_users, :region_id, :integer + Admin.const_set "RegionalUser", Class.new(Admin::User) { belongs_to(:region) } + Admin.const_set "Region", Class.new(ActiveRecord::Base) + e = assert_raise(ActiveRecord::AssociationTypeMismatch) { Admin::RegionalUser.new(region: 'wrong value') } + assert_match(/^Region\([^)]+\) expected, got String\([^)]+\)$/, e.message) + ensure + Admin.send :remove_const, "Region" if Admin.const_defined?("Region") + Admin.send :remove_const, "RegionalUser" if Admin.const_defined?("RegionalUser") + connection = ActiveRecord::Base.connection + connection.remove_column :admin_users, :region_id if connection.column_exists?(:admin_users, :region_id) + connection.drop_table :admin_regions if connection.table_exists?(:admin_regions) + end + def test_natural_assignment apple = Firm.create("name" => "Apple") citibank = Account.create("credit_limit" => 10) -- cgit v1.2.3