From 16d98b2a41dec3619b9bd48b6b534406d9d07ef4 Mon Sep 17 00:00:00 2001 From: Alexis Bernard Date: Tue, 30 Oct 2012 15:54:16 +0100 Subject: Fix find_in_batches against string IDs when start option is not specified. Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/relation/batches.rb --- activerecord/test/cases/batches_test.rb | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'activerecord/test/cases') diff --git a/activerecord/test/cases/batches_test.rb b/activerecord/test/cases/batches_test.rb index 16a93d97c6..ad2a749ab4 100644 --- a/activerecord/test/cases/batches_test.rb +++ b/activerecord/test/cases/batches_test.rb @@ -148,4 +148,13 @@ class EachTest < ActiveRecord::TestCase assert_equal nick_order_subscribers[1..-1].map(&:id), subscribers.map(&:id) end + + def test_find_in_batches_should_use_any_column_as_primary_key_when_start_is_not_specified + Subscriber.count('nick') # preheat arel's table cache + assert_queries(Subscriber.count + 1) do + Subscriber.find_each(:batch_size => 1) do |subscriber| + assert_kind_of Subscriber, subscriber + end + end + end end -- cgit v1.2.3