From 29cbfa2f33b2d0e2d16a203941998687af7831db Mon Sep 17 00:00:00 2001 From: Geoff Petrie & Sean Griffin Date: Sun, 1 Jun 2014 11:40:40 -0600 Subject: Test the serialized types of virtual columns in XML The previous tests were passing, because nothing ever looked at the generated XML. What was previously being generated was `...`, which is not consistent with all other cases where there is not a known type. --- activerecord/test/cases/xml_serialization_test.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'activerecord/test/cases/xml_serialization_test.rb') diff --git a/activerecord/test/cases/xml_serialization_test.rb b/activerecord/test/cases/xml_serialization_test.rb index 1a690c01a6..c34e7d5a30 100644 --- a/activerecord/test/cases/xml_serialization_test.rb +++ b/activerecord/test/cases/xml_serialization_test.rb @@ -416,8 +416,9 @@ class DatabaseConnectedXmlSerializationTest < ActiveRecord::TestCase def test_should_support_aliased_attributes xml = Author.select("name as firstname").to_xml - array = Hash.from_xml(xml)['authors'] - assert_equal array.size, array.select { |author| author.has_key? 'firstname' }.size + Author.all.each do |author| + assert xml.include?(%(#{author.name})), xml + end end def test_array_to_xml_including_has_many_association -- cgit v1.2.3