From 6d30002a52133bd105adb29084f4cc72b1ee847f Mon Sep 17 00:00:00 2001
From: Pratik Naik <pratiknaik@gmail.com>
Date: Fri, 22 Jan 2010 00:51:45 +0530
Subject: Revert "Refactoring attributes/types" [#3348 state:open]

This reverts commit f936a1f100e75082081e782e5cceb272885c2df7.

Conflicts:

	activerecord/lib/active_record.rb
	activerecord/lib/active_record/base.rb

Revert "Fixed: #without_typecast should only disable typecasting on the duplicated attributes" [#3387 state:open]

This reverts commit 2831996483c6a045f1f38d8030256eb58d9771c3.

Reason :

  It's not generating attribute methods properly, making object.column 5x slower.
---
 .../test/cases/attributes/typecasting_test.rb      | 120 ---------------------
 1 file changed, 120 deletions(-)
 delete mode 100644 activerecord/test/cases/attributes/typecasting_test.rb

(limited to 'activerecord/test/cases/attributes/typecasting_test.rb')

diff --git a/activerecord/test/cases/attributes/typecasting_test.rb b/activerecord/test/cases/attributes/typecasting_test.rb
deleted file mode 100644
index 8a3b551375..0000000000
--- a/activerecord/test/cases/attributes/typecasting_test.rb
+++ /dev/null
@@ -1,120 +0,0 @@
-require "cases/helper"
-
-class TypecastingTest < ActiveRecord::TestCase
-
-  class TypecastingAttributes < Hash
-    include ActiveRecord::Attributes::Typecasting
-  end
-
-  module MockType
-    class Object
-
-      def cast(value)
-        value
-      end
-
-      def precast(value)
-        value
-      end
-
-      def boolean(value)
-        !value.blank?
-      end
-
-      def appendable?
-        false
-      end
-
-    end
-
-    class Integer < Object
-
-      def cast(value)
-        value.to_i
-      end
-
-      def precast(value)
-        value ? value : 0
-      end
-
-      def boolean(value)
-        !Float(value).zero?
-      end
-
-    end
-
-    class Serialize < Object
-
-      def cast(value)
-        YAML::load(value) rescue value
-      end
-
-      def precast(value)
-        value
-      end
-
-      def appendable?
-        true
-      end
-
-    end
-  end
-
-  def setup
-    @attributes = TypecastingAttributes.new
-    @attributes.types.default = MockType::Object.new
-    @attributes.types['comments_count'] = MockType::Integer.new
-  end
-
-  test "typecast on read" do
-    attributes = @attributes.merge('comments_count' => '5')
-    assert_equal 5, attributes['comments_count']
-  end
-
-  test "typecast on write" do
-    @attributes['comments_count'] = false
-
-    assert_equal 0, @attributes.to_h['comments_count']
-  end
-
-  test "serialized objects" do
-    attributes = @attributes.merge('tags' => [ 'peanut butter' ].to_yaml)
-    attributes.types['tags'] = MockType::Serialize.new
-    attributes['tags'] << 'jelly'
-
-    assert_equal [ 'peanut butter', 'jelly' ], attributes['tags']
-  end
-
-  test "without typecasting" do
-    @attributes.merge!('comments_count' => '5')
-    attributes = @attributes.without_typecast
-    
-    assert_equal '5', attributes['comments_count']
-    assert_equal  5,  @attributes['comments_count'], "Original attributes should typecast"
-  end
-
-
-  test "typecast all attributes" do
-    attributes = @attributes.merge('title' => 'I love sandwiches', 'comments_count' => '5')
-    attributes.typecast!
-
-    assert_equal({ 'title' => 'I love sandwiches', 'comments_count' => 5 }, attributes)
-  end
-
-  test "query for has? value" do
-    attributes = @attributes.merge('comments_count' => '1')
-
-    assert_equal true,  attributes.has?('comments_count')
-    attributes['comments_count'] = '0'
-    assert_equal false,  attributes.has?('comments_count')
-  end
-
-  test "attributes to Hash" do
-    attributes_hash = { 'title' => 'I love sandwiches', 'comments_count' => '5' }
-    attributes = @attributes.merge(attributes_hash)
-
-    assert_equal Hash, attributes.to_h.class
-    assert_equal attributes_hash, attributes.to_h
-  end
-
-end
-- 
cgit v1.2.3