From b98d1e21635d8776de8893cc09bd86c71f6c78f0 Mon Sep 17 00:00:00 2001 From: Jon Leighton Date: Fri, 18 May 2012 20:48:11 +0100 Subject: Perf: Don't load the association for #delete_all. Bug #6289 Conflicts: activerecord/test/cases/associations/has_many_associations_test.rb --- .../test/cases/associations/has_many_associations_test.rb | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'activerecord/test/cases/associations') diff --git a/activerecord/test/cases/associations/has_many_associations_test.rb b/activerecord/test/cases/associations/has_many_associations_test.rb index a28b8e6651..c128ede34f 100644 --- a/activerecord/test/cases/associations/has_many_associations_test.rb +++ b/activerecord/test/cases/associations/has_many_associations_test.rb @@ -1698,4 +1698,16 @@ class HasManyAssociationsTest < ActiveRecord::TestCase assert_equal [bulb1, bulb3], car.bulbs assert_equal [bulb1, bulb3], result end + + test "delete_all, when not loaded, doesn't load the records" do + post = posts(:welcome) + + assert post.taggings_with_delete_all.count > 0 + assert !post.taggings_with_delete_all.loaded? + + # 2 queries: one DELETE and another to update the counter cache + assert_queries(2) do + post.taggings_with_delete_all.delete_all + end + end end -- cgit v1.2.3