From 2b0406cedb61c4c2f74ecca61fc07771e911fd35 Mon Sep 17 00:00:00 2001 From: Doug Barth Date: Fri, 15 Nov 2013 10:29:30 -0800 Subject: Remove tests for not swallowing exceptions. From PR, @tenderlove would prefer to not maintain these tests. --- .../test/cases/adapters/mysql/connection_test.rb | 21 --------------------- .../test/cases/adapters/mysql2/connection_test.rb | 21 --------------------- 2 files changed, 42 deletions(-) (limited to 'activerecord/test/cases/adapters') diff --git a/activerecord/test/cases/adapters/mysql/connection_test.rb b/activerecord/test/cases/adapters/mysql/connection_test.rb index ece0ee77fb..7cc71c8929 100644 --- a/activerecord/test/cases/adapters/mysql/connection_test.rb +++ b/activerecord/test/cases/adapters/mysql/connection_test.rb @@ -164,27 +164,6 @@ class MysqlConnectionTest < ActiveRecord::TestCase end end - def test_mysql_begin_db_transaction_can_throw_an_exception - @connection.expects(:exec_query).with('BEGIN').raises('OH NOES') - assert_raise RuntimeError do - @connection.begin_db_transaction - end - end - - def test_mysql_commit_db_transaction_can_throw_an_exception - @connection.expects(:execute).with('COMMIT').raises('OH NOES') - assert_raise RuntimeError do - @connection.commit_db_transaction - end - end - - def test_mysql_rollback_db_transaction_can_throw_an_exception - @connection.expects(:execute).with('ROLLBACK').raises('OH NOES') - assert_raise RuntimeError do - @connection.rollback_db_transaction - end - end - private def run_without_connection diff --git a/activerecord/test/cases/adapters/mysql2/connection_test.rb b/activerecord/test/cases/adapters/mysql2/connection_test.rb index 943ca9d552..8dc1df1851 100644 --- a/activerecord/test/cases/adapters/mysql2/connection_test.rb +++ b/activerecord/test/cases/adapters/mysql2/connection_test.rb @@ -89,27 +89,6 @@ class MysqlConnectionTest < ActiveRecord::TestCase @connection.execute "DROP TABLE `bar_baz`" end - def test_mysql_begin_db_transaction_can_throw_an_exception - @connection.expects(:execute).with('BEGIN').raises('OH NOES') - assert_raise RuntimeError do - @connection.begin_db_transaction - end - end - - def test_mysql_commit_db_transaction_can_throw_an_exception - @connection.expects(:execute).with('COMMIT').raises('OH NOES') - assert_raise RuntimeError do - @connection.commit_db_transaction - end - end - - def test_mysql_rollback_db_transaction_can_throw_an_exception - @connection.expects(:execute).with('ROLLBACK').raises('OH NOES') - assert_raise RuntimeError do - @connection.rollback_db_transaction - end - end - private def run_without_connection -- cgit v1.2.3