From fcd4c9529c071d3c77cbf57fe733869da0d3fde8 Mon Sep 17 00:00:00 2001 From: Rick Olson Date: Sun, 19 Mar 2006 07:14:48 +0000 Subject: Allow has_many :through associations to find the source association by setting a custom class (closes #4307) [jonathan@bluewire.net.nz] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3973 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- activerecord/lib/active_record/associations.rb | 6 +++--- activerecord/lib/active_record/reflection.rb | 19 ++++++++++++------- 2 files changed, 15 insertions(+), 10 deletions(-) (limited to 'activerecord/lib') diff --git a/activerecord/lib/active_record/associations.rb b/activerecord/lib/active_record/associations.rb index fb4895433d..2ed9e27e7f 100755 --- a/activerecord/lib/active_record/associations.rb +++ b/activerecord/lib/active_record/associations.rb @@ -32,13 +32,13 @@ module ActiveRecord end class HasManyThroughSourceAssociationNotFoundError < ActiveRecordError - def initialize(through_reflection, source_reflection_name) + def initialize(through_reflection, source_reflection_names) @through_reflection = through_reflection - @source_reflection_name = source_reflection_name + @source_reflection_names = source_reflection_names end def message - "Could not find the source association '#{@source_reflection_name}' in model #{@through_reflection.klass}" + "Could not find the source associations #{@source_reflection_names.to_sentence} in model #{@through_reflection.klass}" end end diff --git a/activerecord/lib/active_record/reflection.rb b/activerecord/lib/active_record/reflection.rb index 0d3333e0e1..a8e0227d40 100644 --- a/activerecord/lib/active_record/reflection.rb +++ b/activerecord/lib/active_record/reflection.rb @@ -144,11 +144,18 @@ module ActiveRecord @through_reflection ||= options[:through] ? active_record.reflect_on_association(options[:through]) : false end - def source_reflection_name - @source_reflection_name ||= name.to_s.singularize.to_sym + # Gets an array of possible :through reflection names + # + # [singularized, pluralized] + def source_reflection_names + @source_reflection_names ||= (options[:class_name] ? + [options[:class_name].underscore, options[:class_name].underscore.pluralize] : + [name.to_s.singularize, name] + ).collect { |n| n.to_sym } end - # Gets the source of the through reflection. (The :tags association on Tagging below) + # Gets the source of the through reflection. It checks both a singularized and pluralized form for :belongs_to or :has_many. + # (The :tags association on Tagging below) # # class Post # has_many :tags, :through => :taggings @@ -156,9 +163,7 @@ module ActiveRecord # def source_reflection return nil unless through_reflection - @source_reflection ||= \ - through_reflection.klass.reflect_on_association(source_reflection_name) || # has_many :through a :belongs_to - through_reflection.klass.reflect_on_association(name) # has_many :through a :has_many + @source_reflection ||= source_reflection_names.collect { |name| through_reflection.klass.reflect_on_association(name) }.compact.first end def check_validity! @@ -168,7 +173,7 @@ module ActiveRecord end if source_reflection.nil? - raise HasManyThroughSourceAssociationNotFoundError.new(through_reflection, source_reflection_name) + raise HasManyThroughSourceAssociationNotFoundError.new(through_reflection, source_reflection_names) end if source_reflection.options[:polymorphic] -- cgit v1.2.3