From d929a218c47b7a5ffc3f8989676a99edb992e2aa Mon Sep 17 00:00:00 2001 From: Jack Chen Songyong Date: Fri, 29 Jul 2016 22:29:21 +0800 Subject: check if order contains comma first in does_not_support_reverse? --- activerecord/lib/active_record/relation/query_methods.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'activerecord/lib') diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb index 97acf26516..099bbe1292 100644 --- a/activerecord/lib/active_record/relation/query_methods.rb +++ b/activerecord/lib/active_record/relation/query_methods.rb @@ -1137,7 +1137,7 @@ module ActiveRecord def does_not_support_reverse?(order) # Uses SQL function with multiple arguments. - order.split(',').find { |section| section.count('(') != section.count(')')} || + (order.include?(',') && order.split(',').find { |section| section.count('(') != section.count(')')}) || # Uses "nulls first" like construction. /nulls (first|last)\Z/i.match?(order) end -- cgit v1.2.3