From d345ed40b5783ec2cb43f4434872ea5b2d57d203 Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Mon, 15 Jul 2013 16:16:18 -0700 Subject: use arel rather than slapping together SQL strings --- activerecord/lib/active_record/relation/query_methods.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'activerecord/lib') diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb index a27b6abe2e..f146c1fdb2 100644 --- a/activerecord/lib/active_record/relation/query_methods.rb +++ b/activerecord/lib/active_record/relation/query_methods.rb @@ -285,8 +285,10 @@ module ActiveRecord references!(references) if references.any? # if a symbol is given we prepend the quoted table name - args = args.map { |arg| - arg.is_a?(Symbol) ? "#{quoted_table_name}.#{arg} ASC" : arg + args = args.map! { |arg| + arg.is_a?(Symbol) ? + Arel::Nodes::Ascending.new(klass.arel_table[arg]) : + arg } self.order_values = args + self.order_values -- cgit v1.2.3