From b67ec8ba20099c8b39bf344f385bbbd2b9c8f47d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20Valim?= Date: Thu, 10 Jun 2010 19:39:09 +0200 Subject: class_attribute is not a direct replacement of class_inheritable_*. If you are setting a hash or an array in class_attribute or you need to freeze it, to ensure people won't modify it in place or you need to dup it on inheritance. --- activerecord/lib/active_record/observer.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'activerecord/lib') diff --git a/activerecord/lib/active_record/observer.rb b/activerecord/lib/active_record/observer.rb index ed0f039597..0ea7fe7365 100644 --- a/activerecord/lib/active_record/observer.rb +++ b/activerecord/lib/active_record/observer.rb @@ -88,7 +88,7 @@ module ActiveRecord # class Observer < ActiveModel::Observer class_attribute :observed_methods - self.observed_methods = [] + self.observed_methods = [].freeze def initialize super @@ -97,7 +97,11 @@ module ActiveRecord def self.method_added(method) method = method.to_sym - observed_methods << method if ActiveRecord::Callbacks::CALLBACKS.include?(method) + + if ActiveRecord::Callbacks::CALLBACKS.include?(method) + self.observed_methods += [method] + self.observed_methods.freeze + end end protected -- cgit v1.2.3