From 7ad26e8a45c2c04a5b9adfa9fb4979d906771f5b Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Fri, 20 Sep 2013 11:50:14 -0700 Subject: generate fewer objects when grouping --- activerecord/lib/active_record/associations/preloader.rb | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'activerecord/lib') diff --git a/activerecord/lib/active_record/associations/preloader.rb b/activerecord/lib/active_record/associations/preloader.rb index d978a083b3..fd294051d4 100644 --- a/activerecord/lib/active_record/associations/preloader.rb +++ b/activerecord/lib/active_record/associations/preloader.rb @@ -134,11 +134,13 @@ module ActiveRecord end def grouped_records(association) - Hash[ - records_by_reflection(association).map do |reflection, records| - [reflection, records.group_by { |record| association_klass(reflection, record) }] - end - ] + reflection_records = records_by_reflection(association) + + reflection_records.each_with_object({}) do |(reflection, records),h| + h[reflection] = records.group_by { |record| + association_klass(reflection, record) + } + end end def records_by_reflection(association) -- cgit v1.2.3