From 19ba522b90f4b3e5daf469fbbccce708a8cc70ce Mon Sep 17 00:00:00 2001 From: Kasper Timm Hansen Date: Thu, 5 May 2016 17:04:21 +0200 Subject: [ci skip] Don't promote SQL interpolation. After fb898e9, the `before_destroy` had some code that used SQL interpolation left over. Don't think we should promote that even if the values aren't directly from user input. --- activerecord/lib/active_record/callbacks.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'activerecord/lib') diff --git a/activerecord/lib/active_record/callbacks.rb b/activerecord/lib/active_record/callbacks.rb index 7c4f1b2bb3..5d4d9379f0 100644 --- a/activerecord/lib/active_record/callbacks.rb +++ b/activerecord/lib/active_record/callbacks.rb @@ -54,8 +54,8 @@ module ActiveRecord # # class Firm < ActiveRecord::Base # # Destroys the associated clients and people when the firm is destroyed - # before_destroy { |record| Person.where("firm_id = #{record.id}").destroy_all } - # before_destroy { |record| Client.where("client_of = #{record.id}").destroy_all } + # before_destroy { |record| Person.where(firm_id: record.id).destroy_all } + # before_destroy { |record| Client.where(client_of: record.id).destroy_all } # end # # == Inheritable callback queues -- cgit v1.2.3