From ed6c3c17f79bd4b5ad91e2473193551e3441769e Mon Sep 17 00:00:00 2001 From: Rick Olson Date: Mon, 27 Mar 2006 08:09:36 +0000 Subject: Fixed eager loading so that an aliased table cannot clash with a has_and_belongs_to_many join table [Rick] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- activerecord/lib/active_record/associations.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'activerecord/lib/active_record') diff --git a/activerecord/lib/active_record/associations.rb b/activerecord/lib/active_record/associations.rb index dcb0f31684..116e5fb5e2 100755 --- a/activerecord/lib/active_record/associations.rb +++ b/activerecord/lib/active_record/associations.rb @@ -1367,7 +1367,8 @@ module ActiveRecord table_index = join_dependency.table_aliases[aliased_table_name] @aliased_table_name = @aliased_table_name[0..active_record.connection.table_alias_length-3] + "_#{table_index+1}" if table_index > 0 end - + join_dependency.table_aliases[aliased_table_name] += 1 + if reflection.macro == :has_and_belongs_to_many || (reflection.macro == :has_many && reflection.options[:through]) @aliased_join_table_name = reflection.macro == :has_and_belongs_to_many ? reflection.options[:join_table] : reflection.through_reflection.klass.table_name unless join_dependency.table_aliases[aliased_join_table_name].zero? @@ -1377,7 +1378,6 @@ module ActiveRecord end join_dependency.table_aliases[aliased_join_table_name] += 1 end - join_dependency.table_aliases[aliased_table_name] += 1 end def association_join -- cgit v1.2.3