From c0eb542e57fe6eaa959218c1a7026e53673ba0cb Mon Sep 17 00:00:00 2001 From: Jack Date: Fri, 29 Jul 2016 19:00:45 +0800 Subject: have does_not_support_reverse? support sql functions with commas in nested brackets --- activerecord/lib/active_record/relation/query_methods.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'activerecord/lib/active_record') diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb index 0749bb30b5..97acf26516 100644 --- a/activerecord/lib/active_record/relation/query_methods.rb +++ b/activerecord/lib/active_record/relation/query_methods.rb @@ -1137,7 +1137,7 @@ module ActiveRecord def does_not_support_reverse?(order) # Uses SQL function with multiple arguments. - /\([^()]*,[^()]*\)/.match?(order) || + order.split(',').find { |section| section.count('(') != section.count(')')} || # Uses "nulls first" like construction. /nulls (first|last)\Z/i.match?(order) end -- cgit v1.2.3