From 7e0b6b25288c753071c0d36eea1772776b2fcc2a Mon Sep 17 00:00:00 2001 From: Jon Leighton Date: Fri, 13 Apr 2012 13:15:23 +0100 Subject: doesn't make sense for select! to take a block --- activerecord/lib/active_record/relation/query_methods.rb | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) (limited to 'activerecord/lib/active_record') diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb index ffca88f69f..6b7e03f9f7 100644 --- a/activerecord/lib/active_record/relation/query_methods.rb +++ b/activerecord/lib/active_record/relation/query_methods.rb @@ -99,14 +99,9 @@ module ActiveRecord end end - def select!(value = Proc.new) - if block_given? - # TODO: test - to_a.select! { |*block_args| value.call(*block_args) } - else - self.select_values += Array.wrap(value) - self - end + def select!(value) + self.select_values += Array.wrap(value) + self end def group(*args) -- cgit v1.2.3