From 376ffe0ea2e59dc51461122210729c05a10fb443 Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Wed, 26 Sep 2018 06:10:32 +0900 Subject: Remove `counter_cache_target` which is no longer called `counter_cache_target` is called only when updated counter cache in replacing target, but it was already removed at #33913. --- .../lib/active_record/associations/belongs_to_association.rb | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) (limited to 'activerecord/lib/active_record') diff --git a/activerecord/lib/active_record/associations/belongs_to_association.rb b/activerecord/lib/active_record/associations/belongs_to_association.rb index 544aec5e8b..11a89366aa 100644 --- a/activerecord/lib/active_record/associations/belongs_to_association.rb +++ b/activerecord/lib/active_record/associations/belongs_to_association.rb @@ -61,11 +61,7 @@ module ActiveRecord def update_counters(by) if require_counter_update? && foreign_key_present? - if target && !stale_target? - target.increment!(reflection.counter_cache_column, by, touch: reflection.options[:touch]) - else - counter_cache_target.update_counters(reflection.counter_cache_column => by, touch: reflection.options[:touch]) - end + reader.increment!(reflection.counter_cache_column, by, touch: reflection.options[:touch]) end end @@ -96,11 +92,6 @@ module ActiveRecord inverse && inverse.has_one? end - def counter_cache_target - primary_key = reflection.association_primary_key(klass) - klass.unscoped.where!(primary_key => owner._read_attribute(reflection.foreign_key)) - end - def stale_state result = owner._read_attribute(reflection.foreign_key) { |n| owner.send(:missing_attribute, n, caller) } result && result.to_s -- cgit v1.2.3