From 0d513699710216ee57dfd9ca678af10630fc9130 Mon Sep 17 00:00:00 2001
From: Ryuta Kamizono <kamipo@gmail.com>
Date: Sat, 10 Sep 2016 21:41:37 +0900
Subject: Rename variable name that returning `type_for` to `type` from
 `column`

`column_for` was changed to `type_for` to return `type` object at
36bd52b4. But variable name is still `column`. It is very confusing.
Rename variable name `column` to `type` for readability.
---
 .../lib/active_record/relation/calculations.rb         | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

(limited to 'activerecord/lib/active_record/relation')

diff --git a/activerecord/lib/active_record/relation/calculations.rb b/activerecord/lib/active_record/relation/calculations.rb
index a796e35261..9dd2410e51 100644
--- a/activerecord/lib/active_record/relation/calculations.rb
+++ b/activerecord/lib/active_record/relation/calculations.rb
@@ -252,11 +252,11 @@ module ActiveRecord
         result = @klass.connection.select_all(query_builder, nil, bound_attributes)
         row    = result.first
         value  = row && row.values.first
-        column = result.column_types.fetch(column_alias) do
+        type   = result.column_types.fetch(column_alias) do
           type_for(column_name)
         end
 
-        type_cast_calculated_value(value, column, operation)
+        type_cast_calculated_value(value, type, operation)
       end
 
       def execute_grouped_calculation(operation, column_name, distinct) #:nodoc:
@@ -310,18 +310,16 @@ module ActiveRecord
 
         Hash[calculated_data.map do |row|
           key = group_columns.map { |aliaz, col_name|
-            column = type_for(col_name) do
-              calculated_data.column_types.fetch(aliaz) do
-                Type.default_value
-              end
+            type = type_for(col_name) do
+              calculated_data.column_types.fetch(aliaz, Type.default_value)
             end
-            type_cast_calculated_value(row[aliaz], column)
+            type_cast_calculated_value(row[aliaz], type)
           }
           key = key.first if key.size == 1
           key = key_records[key] if associated
 
-          column_type = calculated_data.column_types.fetch(aggregate_alias) { type_for(column_name) }
-          [key, type_cast_calculated_value(row[aggregate_alias], column_type, operation)]
+          type = calculated_data.column_types.fetch(aggregate_alias) { type_for(column_name) }
+          [key, type_cast_calculated_value(row[aggregate_alias], type, operation)]
         end]
       end
 
@@ -356,7 +354,7 @@ module ActiveRecord
         when "count"   then value.to_i
         when "sum"     then type.deserialize(value || 0)
         when "average" then value.respond_to?(:to_d) ? value.to_d : value
-          else type.deserialize(value)
+        else type.deserialize(value)
         end
       end
 
-- 
cgit v1.2.3