From 6392cd91b05814d5f7735d458c51cd11c6c4367d Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Tue, 14 Jan 2014 11:49:44 -0800 Subject: we should not be copying these. fixes test_find_all_using_where_with_relation_with_bound_values --- activerecord/lib/active_record/relation/query_methods.rb | 4 ---- 1 file changed, 4 deletions(-) (limited to 'activerecord/lib/active_record/relation/query_methods.rb') diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb index 309e8a564d..3e04ff2a80 100644 --- a/activerecord/lib/active_record/relation/query_methods.rb +++ b/activerecord/lib/active_record/relation/query_methods.rb @@ -916,10 +916,6 @@ module ActiveRecord #TODO: Remove duplication with: /activerecord/lib/active_record/sanitization.rb:113 values = Hash === other.first ? other.first.values : other - values.grep(ActiveRecord::Relation) do |rel| - self.bind_values += rel.bind_values - end - [@klass.send(:sanitize_sql, other.empty? ? opts : ([opts] + other))] when Hash opts = PredicateBuilder.resolve_column_aliases(klass, opts) -- cgit v1.2.3