From c0bce43e903fe42645c16a8062ce1cd970217f40 Mon Sep 17 00:00:00 2001 From: Jeremy Kemper Date: Fri, 10 Nov 2006 19:18:07 +0000 Subject: Oracle: fix limited id selection for eager loading. Closes #6515. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5480 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- .../connection_adapters/abstract/schema_statements.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'activerecord/lib/active_record/connection_adapters/abstract') diff --git a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb index a098c02829..599d04e593 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb @@ -280,8 +280,11 @@ module ActiveRecord sql << " NOT NULL" if options[:null] == false end - # SELECT DISTINCT clause for a given set of columns. PostgreSQL overrides this for custom DISTINCT syntax. - def distinct(columns, *order_columns) + # SELECT DISTINCT clause for a given set of columns and a given ORDER BY clause. + # Both PostgreSQL and Oracle overrides this for custom DISTINCT syntax. + # + # distinct("posts.id", "posts.created_at desc") + def distinct(columns, order_by) "DISTINCT #{columns}" end end -- cgit v1.2.3