From b51c3399eb0cbf07e64bd7a33d176eae3010d5c0 Mon Sep 17 00:00:00 2001 From: Jeremy Kemper Date: Sat, 19 Nov 2005 06:47:26 +0000 Subject: Don't generate read methods for columns whose names are not valid ruby method names. References #2946. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3089 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- activerecord/lib/active_record/base.rb | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'activerecord/lib/active_record/base.rb') diff --git a/activerecord/lib/active_record/base.rb b/activerecord/lib/active_record/base.rb index 550b657102..2f7812d17b 100755 --- a/activerecord/lib/active_record/base.rb +++ b/activerecord/lib/active_record/base.rb @@ -1563,7 +1563,16 @@ module ActiveRecord #:nodoc: self.class.read_methods << attr_name end - self.class.class_eval("def #{symbol}; #{access_code}; end") + begin + self.class.class_eval("def #{symbol}; #{access_code}; end") + rescue SyntaxError => err + self.class.read_methods.delete(attr_name) + if logger + logger.warn "Exception occured during reader method compilation." + logger.warn "Maybe #{attr_name} is not a valid Ruby identifier?" + logger.warn "#{err.message}" + end + end end # Returns true if the attribute is of a text column and marked for serialization. -- cgit v1.2.3