From 51ab5cb0432c483422112ebbb274855a3fa5ecc8 Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Sun, 31 Mar 2019 09:45:44 +0900 Subject: Follow up tweaks b89a3e7e638a50c648a17d09c48b49b707e1d90d [ci skip] * use backticks instead of `+` * and more (e.g. missed replacing `Array#excluding` and `Enumerable#excluding` in b89a3e7e638a50c648a17d09c48b49b707e1d90d) --- activerecord/CHANGELOG.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'activerecord/CHANGELOG.md') diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 432ac641c6..37f31462b3 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -348,7 +348,7 @@ *Gannon McGibbon* -* Cached columns_hash fields should be excluded from ResultSet#column_types +* Cached `columns_hash` fields should be excluded from `ResultSet#column_types`. PR #34528 addresses the inconsistent behaviour when attribute is defined for an ignored column. The following test was passing for SQLite and MySQL, but failed for PostgreSQL: @@ -379,12 +379,12 @@ * Make the implicit order column configurable. - When calling ordered finder methods such as +first+ or +last+ without an + When calling ordered finder methods such as `first` or `last` without an explicit order clause, ActiveRecord sorts records by primary key. This can result in unpredictable and surprising behaviour when the primary key is not an auto-incrementing integer, for example when it's a UUID. This change makes it possible to override the column used for implicit ordering such - that +first+ and +last+ will return more predictable results. + that `first` and `last` will return more predictable results. Example: @@ -530,10 +530,10 @@ * Enum raises on invalid definition values - When defining a Hash enum it can be easy to use [] instead of {}. This + When defining a Hash enum it can be easy to use `[]` instead of `{}`. This commit checks that only valid definition values are provided, those can be a Hash, an array of Symbols or an array of Strings. Otherwise it - raises an ArgumentError. + raises an `ArgumentError`. Fixes #33961 -- cgit v1.2.3