From 07b4078eb664dd45b1526a85358574ea8e669ce3 Mon Sep 17 00:00:00 2001 From: Sean Griffin Date: Fri, 12 Jun 2015 11:00:27 -0600 Subject: Don't crash when mutating attributes in a getter If a getter has side effects on the DB, `changes_applied` will be called twice. The second time will try and remove the changed attributes cache, and will crash because it's already been unset. This also demonstrates that we shouldn't assume that calling getters won't change the value of `changed_attributes`, and we need to clear the cache if an attribute is modified. Fixes #20531. --- activerecord/CHANGELOG.md | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'activerecord/CHANGELOG.md') diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 14906e441b..d389d7f6fe 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -1,3 +1,10 @@ +* Fixed an error which would occur in dirty checking when calling + `update_attributes` from a getter. + + Fixes #20531. + + *Sean Griffin* + * Make `remove_foreign_key` reversible. Any foreign key options must be specified, similar to `remove_column`. -- cgit v1.2.3