From ce06b8a56c5647b9b963c2331e3912fbc54e950c Mon Sep 17 00:00:00 2001 From: Carlos Antonio da Silva Date: Sat, 11 Aug 2012 13:33:27 -0300 Subject: Refactor model name logic and make it a real private class method Under a "private" call, class methods are not real private methods, they're public just like any other method. Make model_name_from_record_or_class a private class method, and nodoc it. --- activemodel/lib/active_model/naming.rb | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'activemodel') diff --git a/activemodel/lib/active_model/naming.rb b/activemodel/lib/active_model/naming.rb index 2102282c02..c0d93e5d53 100644 --- a/activemodel/lib/active_model/naming.rb +++ b/activemodel/lib/active_model/naming.rb @@ -298,12 +298,15 @@ module ActiveModel model_name_from_record_or_class(record_or_class).param_key end - private - def self.model_name_from_record_or_class(record_or_class) - return record_or_class.model_name if record_or_class.respond_to?(:model_name) - return record_or_class.to_model.class.model_name if record_or_class.respond_to?(:to_model) + def self.model_name_from_record_or_class(record_or_class) #:nodoc: + if record_or_class.respond_to?(:model_name) + record_or_class.model_name + elsif record_or_class.respond_to?(:to_model) + record_or_class.to_model.class.model_name + else record_or_class.class.model_name end + end + private_class_method :model_name_from_record_or_class end - end -- cgit v1.2.3