From 5d93ef8f459254f075616d37763611ad87d86b30 Mon Sep 17 00:00:00 2001 From: Phil Calvin Date: Mon, 20 May 2013 12:13:21 -0700 Subject: Fix regression in has_secure_password. If the confirmation was blank, but the password wasn't, it would still save. --- activemodel/test/cases/secure_password_test.rb | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'activemodel/test') diff --git a/activemodel/test/cases/secure_password_test.rb b/activemodel/test/cases/secure_password_test.rb index 02cd3b8a93..0b900d934d 100644 --- a/activemodel/test/cases/secure_password_test.rb +++ b/activemodel/test/cases/secure_password_test.rb @@ -94,4 +94,13 @@ class SecurePasswordTest < ActiveModel::TestCase @user.password_confirmation = "" assert @user.valid?(:update), "user should be valid" end + + test "will not save if confirmation is blank but password is not" do + @user.password = "password" + @user.password_confirmation = "" + assert_not @user.valid?(:create) + + @user.password_confirmation = "password" + assert @user.valid?(:create) + end end -- cgit v1.2.3