From 52a096275a32c0c5d5125280f144e1e0d893d1f3 Mon Sep 17 00:00:00 2001 From: Lawrence Pit Date: Sun, 17 Jul 2011 14:51:34 +1000 Subject: Made attribute_method_matchers_cache private + doc --- activemodel/lib/active_model/attribute_methods.rb | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) (limited to 'activemodel/lib') diff --git a/activemodel/lib/active_model/attribute_methods.rb b/activemodel/lib/active_model/attribute_methods.rb index 15abab87d7..bdc0eb4a0d 100644 --- a/activemodel/lib/active_model/attribute_methods.rb +++ b/activemodel/lib/active_model/attribute_methods.rb @@ -61,9 +61,6 @@ module ActiveModel included do class_attribute :attribute_method_matchers, :instance_writer => false self.attribute_method_matchers = [] - - class_attribute :attribute_method_matchers_cache, :instance_writer => false - self.attribute_method_matchers_cache = {} end module ClassMethods @@ -343,6 +340,19 @@ module ActiveModel end private + # The methods +method_missing+ and +respond_to?+ of this module are + # invoked often in a typical rails, both of which invoke the method + # +match_attribute_method?+. The latter method iterates through an + # array doing regular expression matches, which results in a lot of + # object creations. Most of the times it returns a +nil+ match. As the + # match result is always the same given a +method_name+, this cache is + # used to alleviate the GC, which ultimately also speeds up the app + # significantly (in our case our test suite finishes 10% faster with + # this cache). + def attribute_method_matchers_cache + @attribute_method_matchers_cache ||= {} + end + def attribute_method_matcher(method_name) if attribute_method_matchers_cache.key?(method_name) attribute_method_matchers_cache[method_name] -- cgit v1.2.3