From 9906eb135575ea6dd154257b8c977321c4b1adb2 Mon Sep 17 00:00:00 2001 From: Richard Livsey Date: Fri, 7 Jun 2013 12:41:05 +0200 Subject: Docfix: Use public interface instead of setting instance variables Dynamically setting instance variables based on user input probably isn't a great idea. Better to go through the setter methods provided by attr_accessor. --- activemodel/lib/active_model/serializers/json.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'activemodel/lib/active_model/serializers/json.rb') diff --git a/activemodel/lib/active_model/serializers/json.rb b/activemodel/lib/active_model/serializers/json.rb index 9d984b7a18..05e2e089e5 100644 --- a/activemodel/lib/active_model/serializers/json.rb +++ b/activemodel/lib/active_model/serializers/json.rb @@ -109,7 +109,7 @@ module ActiveModel # # def attributes=(hash) # hash.each do |key, value| - # instance_variable_set("@#{key}", value) + # send("#{key}=", value) # end # end # -- cgit v1.2.3