From 7efd77fae58a02c6014211a8f2f9bcce3f4844cc Mon Sep 17 00:00:00 2001
From: David Heinemeier Hansson <david@loudthinking.com>
Date: Tue, 2 Aug 2016 14:26:56 -0700
Subject: Fix tests against ActiveSupport::Durations

---
 activejob/test/cases/exceptions_test.rb | 73 ++++++++++++++++++++-------------
 1 file changed, 45 insertions(+), 28 deletions(-)

(limited to 'activejob/test/cases')

diff --git a/activejob/test/cases/exceptions_test.rb b/activejob/test/cases/exceptions_test.rb
index 9ad73ff93c..58d87a339a 100644
--- a/activejob/test/cases/exceptions_test.rb
+++ b/activejob/test/cases/exceptions_test.rb
@@ -1,59 +1,76 @@
 require 'helper'
 require 'jobs/retry_job'
 
-class ExceptionsTest < ActiveSupport::TestCase
+class ExceptionsTest < ActiveJob::TestCase
   setup do
     JobBuffer.clear
+    skip if ActiveJob::Base.queue_adapter.is_a?(ActiveJob::QueueAdapters::InlineAdapter)
   end
 
   test "successfully retry job throwing exception against defaults" do
-    RetryJob.perform_later 'DefaultsError', 5
+    perform_enqueued_jobs do
+      RetryJob.perform_later 'DefaultsError', 5
 
-    assert_equal [
-      "Raised DefaultsError for the 1st time",
-      "Raised DefaultsError for the 2nd time",
-      "Raised DefaultsError for the 3rd time",
-      "Raised DefaultsError for the 4th time",
-      "Successfully completed job" ], JobBuffer.values
+      assert_equal [
+        "Raised DefaultsError for the 1st time",
+        "Raised DefaultsError for the 2nd time",
+        "Raised DefaultsError for the 3rd time",
+        "Raised DefaultsError for the 4th time",
+        "Successfully completed job" ], JobBuffer.values
+    end
   end
 
   test "successfully retry job throwing exception against higher limit" do
-    RetryJob.perform_later 'ShortWaitTenAttemptsError', 9
-    assert_equal 9, JobBuffer.values.count
+    perform_enqueued_jobs do
+      RetryJob.perform_later 'ShortWaitTenAttemptsError', 9
+      assert_equal 9, JobBuffer.values.count
+    end
   end
 
   test "failed retry job when exception kept occurring against defaults" do
-    begin
-      RetryJob.perform_later 'DefaultsError', 6
-      assert_equal "Raised DefaultsError for the 5th time", JobBuffer.last_value
-    rescue DefaultsError
-      pass
+    perform_enqueued_jobs do
+      begin
+        RetryJob.perform_later 'DefaultsError', 6
+        assert_equal "Raised DefaultsError for the 5th time", JobBuffer.last_value
+      rescue DefaultsError
+        pass
+      end
     end
   end
 
   test "failed retry job when exception kept occurring against higher limit" do
-    begin
-      RetryJob.perform_later 'ShortWaitTenAttemptsError', 11
-      assert_equal "Raised ShortWaitTenAttemptsError for the 10th time", JobBuffer.last_value
-    rescue ShortWaitTenAttemptsError
-      pass
+    perform_enqueued_jobs do
+      begin
+        RetryJob.perform_later 'ShortWaitTenAttemptsError', 11
+        assert_equal "Raised ShortWaitTenAttemptsError for the 10th time", JobBuffer.last_value
+      rescue ShortWaitTenAttemptsError
+        pass
+      end
     end
   end
 
   test "discard job" do
-    RetryJob.perform_later 'DiscardableError', 2
-    assert_equal "Raised DiscardableError for the 1st time", JobBuffer.last_value
+    perform_enqueued_jobs do
+      RetryJob.perform_later 'DiscardableError', 2
+      assert_equal "Raised DiscardableError for the 1st time", JobBuffer.last_value
+    end
   end
 
   test "custom handling of job that exceeds retry attempts" do
-    RetryJob.perform_later 'CustomCatchError', 6
-    assert_equal "Dealt with a job that failed to retry in a custom way", JobBuffer.last_value
+    perform_enqueued_jobs do
+      RetryJob.perform_later 'CustomCatchError', 6
+      assert_equal "Dealt with a job that failed to retry in a custom way", JobBuffer.last_value
+    end
   end
-end
 
-class ExponentiallyBackoffExceptionsTest < ActiveJob::TestCase
-  setup do
-    JobBuffer.clear
+  test "long wait job" do
+    travel_to Time.now
+  
+    perform_enqueued_jobs do
+      assert_performed_with at: (Time.now + 3600.seconds).to_i do
+        RetryJob.perform_later 'LongWaitError', 5
+      end
+    end
   end
 
   test "exponentially retrying job" do
-- 
cgit v1.2.3