From f2b31cd6d1f4b4b0a7095ec25456bd560587330a Mon Sep 17 00:00:00 2001 From: Robin Dupret Date: Wed, 31 Dec 2014 16:31:25 +0100 Subject: Tiny follow-up to #18260 [ci skip] Indent the list content by 4 spaces instead of 2 to match the other changelog files. Also wrap the lines around 80 chars. Finally update the documentation example with nit-picky things. --- activejob/CHANGELOG.md | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'activejob/CHANGELOG.md') diff --git a/activejob/CHANGELOG.md b/activejob/CHANGELOG.md index be8c98963c..afdd42be33 100644 --- a/activejob/CHANGELOG.md +++ b/activejob/CHANGELOG.md @@ -1,8 +1,9 @@ -* `ActiveJob::Base.deserialize` delegates to the job class +* `ActiveJob::Base.deserialize` delegates to the job class - Since `ActiveJob::Base#deserialize` can be overridden by subclasses (like `ActiveJob::Base#serialize`) - this allows jobs to attach arbitrary metadata when they get serialized and read it back when they get - performed. E.g. + + Since `ActiveJob::Base#deserialize` can be overridden by subclasses (like + `ActiveJob::Base#serialize`) this allows jobs to attach arbitrary metadata + when they get serialized and read it back when they get performed. Example: class DeliverWebhookJob < ActiveJob::Base def serialize @@ -10,17 +11,17 @@ end def deserialize(job_data) - super(job_data) + super @attempt_number = job_data['attempt_number'] end - rescue_from(TimeoutError) do |ex| - raise ex if @attempt_number > 5 + rescue_from(TimeoutError) do |exception| + raise exception if @attempt_number > 5 retry_job(wait: 10) end end - *Isaac Seymour* + *Isaac Seymour* Please check [4-2-stable](https://github.com/rails/rails/blob/4-2-stable/activejob/CHANGELOG.md) for previous changes. -- cgit v1.2.3