From ab4ed8c78681e0bda514bf6343d54914841a0e72 Mon Sep 17 00:00:00 2001
From: Sudara <sudara@alonetone.com>
Date: Thu, 6 Jun 2019 22:06:14 +0200
Subject: Ensure non-mouse/programmatic clicks work with data-remote

---
 .../assets/javascripts/rails-ujs/features/remote.coffee    |  4 ++--
 actionview/test/ujs/public/test/data-remote.js             | 14 ++++++++++++++
 2 files changed, 16 insertions(+), 2 deletions(-)

(limited to 'actionview')

diff --git a/actionview/app/assets/javascripts/rails-ujs/features/remote.coffee b/actionview/app/assets/javascripts/rails-ujs/features/remote.coffee
index a5b61220bb..d1aeef56c7 100644
--- a/actionview/app/assets/javascripts/rails-ujs/features/remote.coffee
+++ b/actionview/app/assets/javascripts/rails-ujs/features/remote.coffee
@@ -88,6 +88,6 @@ Rails.preventInsignificantClick = (e) ->
   data = link.getAttribute('data-params')
   metaClick = e.metaKey or e.ctrlKey
   insignificantMetaClick = metaClick and method is 'GET' and not data
-  primaryMouseKey = e.button is 0
-  e.stopImmediatePropagation() if not primaryMouseKey or insignificantMetaClick
+  nonPrimaryMouseClick = e.button? and e.button isnt 0
+  e.stopImmediatePropagation() if nonPrimaryMouseClick or insignificantMetaClick
 
diff --git a/actionview/test/ujs/public/test/data-remote.js b/actionview/test/ujs/public/test/data-remote.js
index 9e41067549..16ea114f3b 100644
--- a/actionview/test/ujs/public/test/data-remote.js
+++ b/actionview/test/ujs/public/test/data-remote.js
@@ -82,6 +82,20 @@ asyncTest('right/mouse-wheel-clicking on a link does not fire ajaxyness', 0, fun
   setTimeout(function() { start() }, 13)
 })
 
+asyncTest('clicking on a link via a non-mouse Event (such as from js) works', 1, function() {
+  var link = $('a[data-remote]')
+
+  link
+    .removeAttr('data-params')
+    .bindNative('ajax:beforeSend', function() {
+      ok(true, 'ajax should be triggered')
+    })
+
+  Rails.fire(link[0], 'click')
+
+  setTimeout(function() { start() }, 13)
+})
+
 asyncTest('ctrl-clicking on a link still fires ajax for non-GET links and for links with "data-params"', 2, function() {
   var link = $('a[data-remote]')
 
-- 
cgit v1.2.3