From 8d2866bb80fbe81acb04f5b0c44f152f571fb29f Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Fri, 2 Aug 2019 03:30:21 +0900 Subject: You give jruby_skip & rubinius_skip a good name This hack prevails everywhere in the codebase by being copy & pasted, and it's actually not a negative thing but a necessary thing for framework implementors, so it should better have a name and be a thing. And with this commit, activesupport/test/abstract_unit.rb now doesn't silently autoload AS::TestCase, so we're ready to establish clearner environment for running AS tests (probably in later commits) --- actionview/test/abstract_unit.rb | 11 ----------- 1 file changed, 11 deletions(-) (limited to 'actionview') diff --git a/actionview/test/abstract_unit.rb b/actionview/test/abstract_unit.rb index 516631ddb2..debf553689 100644 --- a/actionview/test/abstract_unit.rb +++ b/actionview/test/abstract_unit.rb @@ -192,17 +192,6 @@ end class ActiveSupport::TestCase parallelize - - private - # Skips the current run on Rubinius using Minitest::Assertions#skip - def rubinius_skip(message = "") - skip message if RUBY_ENGINE == "rbx" - end - - # Skips the current run on JRuby using Minitest::Assertions#skip - def jruby_skip(message = "") - skip message if defined?(JRUBY_VERSION) - end end require_relative "../../tools/test_common" -- cgit v1.2.3