From c3e786fc4822017095b605cabfb5ee55d21389b9 Mon Sep 17 00:00:00 2001
From: Willian Gustavo Veiga <beberveiga@gmail.com>
Date: Thu, 25 Jul 2019 16:07:11 -0300
Subject: Issue #36728 - Inputs inside disabled fieldset are not submited on
 remote: true forms

---
 actionview/app/assets/javascripts/rails-ujs/utils/form.coffee | 1 +
 1 file changed, 1 insertion(+)

(limited to 'actionview')

diff --git a/actionview/app/assets/javascripts/rails-ujs/utils/form.coffee b/actionview/app/assets/javascripts/rails-ujs/utils/form.coffee
index 736cab08db..9e11bfa7ed 100644
--- a/actionview/app/assets/javascripts/rails-ujs/utils/form.coffee
+++ b/actionview/app/assets/javascripts/rails-ujs/utils/form.coffee
@@ -11,6 +11,7 @@ Rails.serializeElement = (element, additionalParam) ->
 
   inputs.forEach (input) ->
     return if !input.name || input.disabled
+    return if input.closest('fieldset[disabled]')
     if matches(input, 'select')
       toArray(input.options).forEach (option) ->
         params.push(name: input.name, value: option.value) if option.selected
-- 
cgit v1.2.3


From 64631d83c561510579a04ac8317ab644e52ab714 Mon Sep 17 00:00:00 2001
From: Willian Gustavo Veiga <beberveiga@gmail.com>
Date: Fri, 26 Jul 2019 12:58:22 -0300
Subject: Add test for submitted fields within disabled fieldsets

---
 actionview/test/ujs/public/test/data-remote.js | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

(limited to 'actionview')

diff --git a/actionview/test/ujs/public/test/data-remote.js b/actionview/test/ujs/public/test/data-remote.js
index 16ea114f3b..dbbb383995 100644
--- a/actionview/test/ujs/public/test/data-remote.js
+++ b/actionview/test/ujs/public/test/data-remote.js
@@ -490,4 +490,22 @@ asyncTest('changing a select option without "data-url" attribute still fires aja
   setTimeout(function() { start() }, 20)
 })
 
+asyncTest('inputs inside disabled fieldset are not submited on remote forms', 3, function() {
+  $('form')
+    .append('<fieldset>\
+      <input name="description" value="A wise man" />\
+    </fieldset>')
+    .append('<fieldset disabled="disabled">\
+      <input name="age" />\
+    </fieldset>')
+    .bindNative('ajax:success', function(e, data, status, xhr) {
+      equal(data.params.user_name, 'john')
+      equal(data.params.description, 'A wise man')
+      equal(data.params.age, undefined)
+
+      start()
+    })
+    .triggerNative('submit')
+})
+
 })()
-- 
cgit v1.2.3