From 0855f041df5a46c2f3fd0820864e4139eb37a6c4 Mon Sep 17 00:00:00 2001 From: Nathan Stitt Date: Thu, 1 Aug 2013 13:10:36 -0500 Subject: Add "extname" option to javascript_include_tag ActionView::Helpers.asset_path is where the logic for javascript_include_tag resides. It takes an extname option for specifying the extension or false to not append it. This exposes that option to javascript_include_tag. Without the option files that didn't end with ".js" would get the extension appended to them. This broke JST templates and other file types that should be interpreted as JavaScript but who's file extension isn't ".js" --- actionview/test/template/javascript_helper_test.rb | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'actionview/test/template') diff --git a/actionview/test/template/javascript_helper_test.rb b/actionview/test/template/javascript_helper_test.rb index de6a6eaab3..4703111741 100644 --- a/actionview/test/template/javascript_helper_test.rb +++ b/actionview/test/template/javascript_helper_test.rb @@ -51,6 +51,13 @@ class JavaScriptHelperTest < ActionView::TestCase assert_equal 'foo', output_buffer, 'javascript_tag without a block should not concat to output_buffer' end + # Setting the :extname option will control what extension (if any) is appended to the url for assets + def test_javascript_include_tag + assert_dom_equal "", javascript_include_tag('/foo') + assert_dom_equal "", javascript_include_tag('/foo', extname: false ) + assert_dom_equal "", javascript_include_tag('/foo', extname: '.bar' ) + end + def test_javascript_tag_with_options assert_dom_equal "", javascript_tag("alert('hello')", :id => "the_js_tag") -- cgit v1.2.3