From 9290fc5ce213836f666a97e0e458d98e69a920ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rafael=20Mendon=C3=A7a=20Fran=C3=A7a?=
 <rafaelmfranca@gmail.com>
Date: Wed, 16 Jul 2014 14:28:39 -0300
Subject: Build only one PartialIteration object for loop

---
 .../lib/action_view/renderer/partial_renderer.rb   | 29 ++++++++++++++--------
 1 file changed, 18 insertions(+), 11 deletions(-)

(limited to 'actionview/lib/action_view')

diff --git a/actionview/lib/action_view/renderer/partial_renderer.rb b/actionview/lib/action_view/renderer/partial_renderer.rb
index 6b3c49aa79..bc0215b6c6 100644
--- a/actionview/lib/action_view/renderer/partial_renderer.rb
+++ b/actionview/lib/action_view/renderer/partial_renderer.rb
@@ -4,9 +4,9 @@ module ActionView
   class PartialIteration # :nodoc:
     attr_reader :size, :index
 
-    def initialize(size, index)
+    def initialize(size)
       @size  = size
-      @index = index
+      @index = 0
     end
 
     def first?
@@ -16,6 +16,10 @@ module ActionView
     def last?
       index == size - 1
     end
+
+    def iterate!
+      @index += 1
+    end
   end
 
   # = Action View Partials
@@ -412,16 +416,16 @@ module ActionView
         layout = find_template(layout, @template_keys)
       end
 
-      index = -1
-      @collection.map do |object|
-        index += 1
+      partial_interation = PartialIteration.new(@collection.size)
+      locals[iteration] = partial_interation
 
+      @collection.map do |object|
         locals[as]        = object
-        locals[counter]   = index
-        locals[iteration] = PartialIteration.new(@collection.size, index)
+        locals[counter]   = partial_interation.index
 
         content = template.render(view, locals)
         content = layout.render(view, locals) { content } if layout
+        partial_interation.iterate!
         content
       end
     end
@@ -431,17 +435,20 @@ module ActionView
       cache = {}
       keys  = @locals.keys
 
-      index = -1
+      partial_interation = PartialIteration.new(@collection.size)
+
       @collection.map do |object|
-        index += 1
+        index = partial_interation.index
         path, as, counter, iteration = collection_data[index]
 
         locals[as]        = object
         locals[counter]   = index
-        locals[iteration] = PartialIteration.new(@collection.size, index)
+        locals[iteration] = partial_interation
 
         template = (cache[path] ||= find_template(path, keys + [as, counter]))
-        template.render(view, locals)
+        content = template.render(view, locals)
+        partial_interation.iterate!
+        content
       end
     end
 
-- 
cgit v1.2.3