From 2286fa94716b138a7763e95ade87a7582864bb42 Mon Sep 17 00:00:00 2001 From: Kasper Timm Hansen Date: Fri, 12 Feb 2016 23:28:31 +0100 Subject: Prefer empty? to any?. If the collection isn't empty any? will loop through it. Spare the loop and be more concise with what we're asking the collection about. --- .../lib/action_view/renderer/partial_renderer/collection_caching.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'actionview/lib/action_view/renderer') diff --git a/actionview/lib/action_view/renderer/partial_renderer/collection_caching.rb b/actionview/lib/action_view/renderer/partial_renderer/collection_caching.rb index e6d57b802e..4860f00243 100644 --- a/actionview/lib/action_view/renderer/partial_renderer/collection_caching.rb +++ b/actionview/lib/action_view/renderer/partial_renderer/collection_caching.rb @@ -18,7 +18,7 @@ module ActionView cached_partials = collection_cache.read_multi(*keyed_collection.keys) @collection = keyed_collection.reject { |key, _| cached_partials.key?(key) }.values - rendered_partials = @collection.any? ? yield : [] + rendered_partials = @collection.empty? ? [] : yield index = 0 keyed_collection.map do |cache_key, _| -- cgit v1.2.3