From 23b6a9c0fcb8992e18450d6fe0680bf09685b7db Mon Sep 17 00:00:00 2001 From: Kasper Timm Hansen Date: Mon, 16 May 2016 21:34:16 +0200 Subject: Replace middleware with executor callback. Per request digest caches were added before we had hooks into different units of work that Rails performs. As such the most reliable way to prevent stale cache digests was with a middleware. The middleware prevented staleness in Action Controller requests. However, the executor is superior because it should also prevent staleness when running just Active Job jobs or broadcasting through Action Cable's server. --- actionview/lib/action_view/digestor.rb | 7 ------- 1 file changed, 7 deletions(-) (limited to 'actionview/lib/action_view/digestor.rb') diff --git a/actionview/lib/action_view/digestor.rb b/actionview/lib/action_view/digestor.rb index b99d1af998..53baf044f1 100644 --- a/actionview/lib/action_view/digestor.rb +++ b/actionview/lib/action_view/digestor.rb @@ -6,13 +6,6 @@ module ActionView class Digestor @@digest_mutex = Mutex.new - class PerRequestDigestCacheExpiry < Struct.new(:app) # :nodoc: - def call(env) - ActionView::LookupContext::DetailsKey.clear - app.call(env) - end - end - class << self # Supported options: # -- cgit v1.2.3 From bd49a4b175e056c77610c78ac109eab0c3411af8 Mon Sep 17 00:00:00 2001 From: Kasper Timm Hansen Date: Mon, 16 May 2016 21:38:01 +0200 Subject: Remove extranous spaces from assignment. Leftover from an earlier commit, chose to fix because I was just down in this file. --- actionview/lib/action_view/digestor.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'actionview/lib/action_view/digestor.rb') diff --git a/actionview/lib/action_view/digestor.rb b/actionview/lib/action_view/digestor.rb index 53baf044f1..b91e61da18 100644 --- a/actionview/lib/action_view/digestor.rb +++ b/actionview/lib/action_view/digestor.rb @@ -4,7 +4,7 @@ require 'monitor' module ActionView class Digestor - @@digest_mutex = Mutex.new + @@digest_mutex = Mutex.new class << self # Supported options: -- cgit v1.2.3