From db65f73f2e442eb87228f604d28af2548e7dd823 Mon Sep 17 00:00:00 2001 From: Dmytro Vasin Date: Thu, 13 Apr 2017 16:58:36 +0300 Subject: Fix mistake in JS response parser: - Restore ability to accept ecmascript JS response should not modify DOM. --- actionview/app/assets/javascripts/rails-ujs/utils/ajax.coffee | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'actionview/app') diff --git a/actionview/app/assets/javascripts/rails-ujs/utils/ajax.coffee b/actionview/app/assets/javascripts/rails-ujs/utils/ajax.coffee index 6fabddf65c..26df7b9a3f 100644 --- a/actionview/app/assets/javascripts/rails-ujs/utils/ajax.coffee +++ b/actionview/app/assets/javascripts/rails-ujs/utils/ajax.coffee @@ -64,10 +64,10 @@ processResponse = (response, type) -> if typeof response is 'string' and typeof type is 'string' if type.match(/\bjson\b/) try response = JSON.parse(response) - else if type.match(/\bjavascript\b/) + else if type.match(/\b(?:java|ecma)script\b/) script = document.createElement('script') - script.innerHTML = response - document.body.appendChild(script) + script.text = response + document.head.appendChild(script).parentNode.removeChild(script) else if type.match(/\b(xml|html|svg)\b/) parser = new DOMParser() type = type.replace(/;.+/, '') # remove something like ';charset=utf-8' -- cgit v1.2.3