From ff7948b1c2cbdf5527e40e60a4f2ef7621445d55 Mon Sep 17 00:00:00 2001 From: George Claghorn Date: Sat, 23 Mar 2019 10:04:48 -0400 Subject: Avoid creating ActionText::RichText records unnecessarily Assigning a has_one association for a persisted record saves the change immediately, so attempting to read a rich-text attribute on a persisted record without a corresponding ActionText::RichText would eagerly create one. Avoid assigning the rich text association to fix. --- actiontext/test/unit/model_test.rb | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'actiontext/test') diff --git a/actiontext/test/unit/model_test.rb b/actiontext/test/unit/model_test.rb index f4328ba2ce..af53f88caa 100644 --- a/actiontext/test/unit/model_test.rb +++ b/actiontext/test/unit/model_test.rb @@ -67,4 +67,12 @@ class ActionText::ModelTest < ActiveSupport::TestCase message.update! review_attributes: { id: message.review.id, content: "Great work!" } assert_equal "Great work!", message.review.reload.content.to_plain_text end + + test "building content lazily on existing record" do + message = Message.create!(subject: "Greetings") + + assert_no_difference -> { ActionText::RichText.count } do + assert_kind_of ActionText::RichText, message.content + end + end end -- cgit v1.2.3