From ea881ca85a1a9df3c25e2ee8668d98416a5c1acb Mon Sep 17 00:00:00 2001
From: jasl <jasl9187@hotmail.com>
Date: Wed, 2 Jan 2013 16:48:09 +0800
Subject: fix block.arity raise nil error when not given a block to
 "content_tag_for"

---
 actionpack/CHANGELOG.md                                 | 5 +++++
 actionpack/lib/action_view/helpers/record_tag_helper.rb | 4 +++-
 actionpack/test/template/record_tag_helper_test.rb      | 8 ++++++++
 3 files changed, 16 insertions(+), 1 deletion(-)

(limited to 'actionpack')

diff --git a/actionpack/CHANGELOG.md b/actionpack/CHANGELOG.md
index a681a2dc79..8a9be65d10 100644
--- a/actionpack/CHANGELOG.md
+++ b/actionpack/CHANGELOG.md
@@ -1,5 +1,10 @@
 ## Rails 3.2.10 (unreleased) ##
 
+*   Fix a bug in `ActionView::Helpers::RecordTagHelper::content_tag_for`
+    raise `nil:NilClass` without given a block.
+    
+    *Jasl*
+
 *   Clear url helper methods when routes are reloaded by removing the methods
     explicitly rather than just clearing the module because it didn't work
     properly and could be the source of a memory leak.
diff --git a/actionpack/lib/action_view/helpers/record_tag_helper.rb b/actionpack/lib/action_view/helpers/record_tag_helper.rb
index aae6389445..709b5d2c17 100644
--- a/actionpack/lib/action_view/helpers/record_tag_helper.rb
+++ b/actionpack/lib/action_view/helpers/record_tag_helper.rb
@@ -98,7 +98,9 @@ module ActionView
           options, prefix = prefix, nil if prefix.is_a?(Hash)
           options = options ? options.dup : {}
           options.merge!(:class => "#{dom_class(record, prefix)} #{options[:class]}".strip, :id => dom_id(record, prefix))
-          if block.arity == 0
+          if !block_given?
+            content_tag(tag_name, "", options)
+          elsif block.arity == 0
             content_tag(tag_name, capture(&block), options)
           else
             content_tag(tag_name, capture(record, &block), options)
diff --git a/actionpack/test/template/record_tag_helper_test.rb b/actionpack/test/template/record_tag_helper_test.rb
index f33471ab28..3cb5997a83 100644
--- a/actionpack/test/template/record_tag_helper_test.rb
+++ b/actionpack/test/template/record_tag_helper_test.rb
@@ -81,6 +81,14 @@ class RecordTagHelperTest < ActionView::TestCase
     assert_dom_equal expected, actual
   end
 
+  def test_content_tag_for_collection_without_given_block
+    post_1 = RecordTagPost.new.tap { |post| post.id = 101; post.body = "Hello!"; post.persisted = true }
+    post_2 = RecordTagPost.new.tap { |post| post.id = 102; post.body = "World!"; post.persisted = true }
+    expected = %(<li class="record_tag_post" id="record_tag_post_101"></li>\n<li class="record_tag_post" id="record_tag_post_102"></li>)
+    actual = content_tag_for(:li, [post_1, post_2])
+    assert_dom_equal expected, actual
+  end
+
   def test_div_for_collection
     post_1 = RecordTagPost.new.tap { |post| post.id = 101; post.body = "Hello!"; post.persisted = true }
     post_2 = RecordTagPost.new.tap { |post| post.id = 102; post.body = "World!"; post.persisted = true }
-- 
cgit v1.2.3