From e1c7b5a7f6dc412f0e523265e47fffe7b77e9724 Mon Sep 17 00:00:00 2001 From: Rick Olson Date: Sun, 23 Apr 2006 18:18:17 +0000 Subject: Cache CgiRequest#request_parameters so that multiple calls don't re-parse multipart data. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4256 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- actionpack/CHANGELOG | 2 ++ actionpack/lib/action_controller/cgi_process.rb | 11 ++++++----- 2 files changed, 8 insertions(+), 5 deletions(-) (limited to 'actionpack') diff --git a/actionpack/CHANGELOG b/actionpack/CHANGELOG index 4d44ca8383..25e5643aa1 100644 --- a/actionpack/CHANGELOG +++ b/actionpack/CHANGELOG @@ -1,5 +1,7 @@ *SVN* +* Cache CgiRequest#request_parameters so that multiple calls don't re-parse multipart data. [Rick] + * Diff compared routing options. Allow #assert_recognizes to take a second arg as a hash to specify optional request method [Rick] assert_recognizes({:controller => 'users', :action => 'index'}, 'users') diff --git a/actionpack/lib/action_controller/cgi_process.rb b/actionpack/lib/action_controller/cgi_process.rb index ce8acdf313..09a6000b9f 100644 --- a/actionpack/lib/action_controller/cgi_process.rb +++ b/actionpack/lib/action_controller/cgi_process.rb @@ -64,11 +64,12 @@ module ActionController #:nodoc: end def request_parameters - if ActionController::Base.param_parsers.has_key?(content_type) - CGIMethods.parse_formatted_request_parameters(content_type, @env['RAW_POST_DATA']) - else - CGIMethods.parse_request_parameters(@cgi.params) - end + @request_parameters ||= + if ActionController::Base.param_parsers.has_key?(content_type) + CGIMethods.parse_formatted_request_parameters(content_type, @env['RAW_POST_DATA']) + else + CGIMethods.parse_request_parameters(@cgi.params) + end end def cookies -- cgit v1.2.3