From dbf38a06f4652c0a2fbdaecca21a18f53633bb6e Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Fri, 13 Feb 2015 15:22:58 +0800 Subject: Do not recommend `xhr` since it is going to be deprecated. --- actionpack/lib/action_dispatch/testing/integration.rb | 3 --- 1 file changed, 3 deletions(-) (limited to 'actionpack') diff --git a/actionpack/lib/action_dispatch/testing/integration.rb b/actionpack/lib/action_dispatch/testing/integration.rb index 590fed955a..0fca136f0a 100644 --- a/actionpack/lib/action_dispatch/testing/integration.rb +++ b/actionpack/lib/action_dispatch/testing/integration.rb @@ -314,9 +314,6 @@ module ActionDispatch params: { id: 1 }, headers: { 'X-Extra-Header' => '123' }, env: { 'action_dispatch.custom' => 'custom' } - - xhr :post, '/profile', - params: { id: 1 } MSG end -- cgit v1.2.3 From aca4c82d95721df874ae8ed5da2a476fdec42f11 Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Fri, 13 Feb 2015 15:30:13 +0800 Subject: Improve deprecation message. --- actionpack/lib/action_dispatch/testing/integration.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'actionpack') diff --git a/actionpack/lib/action_dispatch/testing/integration.rb b/actionpack/lib/action_dispatch/testing/integration.rb index 0fca136f0a..eefff8b053 100644 --- a/actionpack/lib/action_dispatch/testing/integration.rb +++ b/actionpack/lib/action_dispatch/testing/integration.rb @@ -306,7 +306,8 @@ module ActionDispatch def non_kwarg_request_warning ActiveSupport::Deprecation.warn(<<-MSG.strip_heredoc) ActionDispatch::Integration::TestCase HTTP request methods will accept only - keyword arguments in future Rails versions. + the following keyword arguments in future Rails versions: + #{REQUEST_KWARGS.join(', ')} Examples: @@ -314,6 +315,7 @@ module ActionDispatch params: { id: 1 }, headers: { 'X-Extra-Header' => '123' }, env: { 'action_dispatch.custom' => 'custom' } + xhr: true MSG end -- cgit v1.2.3