From b377fc067d01b87779459baa0ec6896b6b7fa701 Mon Sep 17 00:00:00 2001 From: Kasper Timm Hansen Date: Sun, 7 Aug 2016 19:59:13 +0200 Subject: Assign config on base instead of on `@controller`. In some test runs `ActionController::Base.enable_fragment_cache_logging` would be false, based on the test order. Turns out it was off because we assigned the config to the `@controller` variable, and not on `ActionController::Base`. The test failure was reproducible with, and now passes after this: ``` bin/test test/controller/log_subscriber_test.rb --seed 19918 ``` --- actionpack/test/controller/log_subscriber_test.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'actionpack/test') diff --git a/actionpack/test/controller/log_subscriber_test.rb b/actionpack/test/controller/log_subscriber_test.rb index 0deeb3865d..231283acdf 100644 --- a/actionpack/test/controller/log_subscriber_test.rb +++ b/actionpack/test/controller/log_subscriber_test.rb @@ -92,7 +92,7 @@ class ACLogSubscriberTest < ActionController::TestCase def setup super - @controller.enable_fragment_cache_logging = true + ActionController::Base.enable_fragment_cache_logging = true @old_logger = ActionController::Base.logger -- cgit v1.2.3