From 20723ca49873076d8fc8c2bf0729568373e31738 Mon Sep 17 00:00:00 2001 From: Roberto Soares Date: Fri, 23 Nov 2012 16:13:08 -0300 Subject: `assert_template` fails with empty string when a template has been rendered For instance, it prevents false positive in this case: file = nil get :index assert_template("#{file}") --- actionpack/test/controller/action_pack_assertions_test.rb | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'actionpack/test') diff --git a/actionpack/test/controller/action_pack_assertions_test.rb b/actionpack/test/controller/action_pack_assertions_test.rb index ca542eb7e2..c653f7e756 100644 --- a/actionpack/test/controller/action_pack_assertions_test.rb +++ b/actionpack/test/controller/action_pack_assertions_test.rb @@ -447,6 +447,13 @@ class AssertTemplateTest < ActionController::TestCase end end + def test_with_empty_string_fails_when_template_rendered + get :hello_world + assert_raise(ActiveSupport::TestCase::Assertion) do + assert_template "" + end + end + def test_passes_with_correct_string get :hello_world assert_template 'hello_world' -- cgit v1.2.3 From 2d6c4ec731861225779f3106f038effb17a27b21 Mon Sep 17 00:00:00 2001 From: Roberto Soares Date: Fri, 23 Nov 2012 18:10:18 -0300 Subject: `assert_template` fails with empty string. --- actionpack/test/controller/action_pack_assertions_test.rb | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'actionpack/test') diff --git a/actionpack/test/controller/action_pack_assertions_test.rb b/actionpack/test/controller/action_pack_assertions_test.rb index c653f7e756..5f559e5b00 100644 --- a/actionpack/test/controller/action_pack_assertions_test.rb +++ b/actionpack/test/controller/action_pack_assertions_test.rb @@ -454,6 +454,13 @@ class AssertTemplateTest < ActionController::TestCase end end + def test_with_empty_string_fails_when_no_template_rendered + get :nothing + assert_raise(ActiveSupport::TestCase::Assertion) do + assert_template "" + end + end + def test_passes_with_correct_string get :hello_world assert_template 'hello_world' -- cgit v1.2.3