From e9051e20aeb2c666db06b6217954737665878db7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20Galdino=20+=20Rafael=20Mendon=C3=A7a=20Fran=C3=A7?= =?UTF-8?q?a?= Date: Mon, 14 May 2012 16:55:13 -0300 Subject: Deprecate `:disable_with` for `button_tag` too --- actionpack/test/template/form_tag_helper_test.rb | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) (limited to 'actionpack/test/template/form_tag_helper_test.rb') diff --git a/actionpack/test/template/form_tag_helper_test.rb b/actionpack/test/template/form_tag_helper_test.rb index 1bfe2856dc..d9f91e952b 100644 --- a/actionpack/test/template/form_tag_helper_test.rb +++ b/actionpack/test/template/form_tag_helper_test.rb @@ -367,7 +367,7 @@ class FormTagHelperTest < ActionView::TestCase end def test_submit_tag - assert_deprecated ":disable_with option is deprecated and will be removed from Rails 4.0. Use :data-disable-with instead" do + assert_deprecated ":disable_with option is deprecated and will be removed from Rails 4.0. Use 'data-disable-with' instead" do assert_dom_equal( %(), submit_tag("Save", :disable_with => "Saving...", :onclick => "alert('hello!')") @@ -376,7 +376,7 @@ class FormTagHelperTest < ActionView::TestCase end def test_submit_tag_with_no_onclick_options - assert_deprecated ":disable_with option is deprecated and will be removed from Rails 4.0. Use :data-disable-with instead" do + assert_deprecated ":disable_with option is deprecated and will be removed from Rails 4.0. Use 'data-disable-with' instead" do assert_dom_equal( %(), submit_tag("Save", :disable_with => "Saving...") @@ -392,7 +392,7 @@ class FormTagHelperTest < ActionView::TestCase end def test_submit_tag_with_confirmation_and_with_disable_with - assert_deprecated ":disable_with option is deprecated and will be removed from Rails 4.0. Use :data-disable-with instead" do + assert_deprecated ":disable_with option is deprecated and will be removed from Rails 4.0. Use 'data-disable-with' instead" do assert_dom_equal( %(), submit_tag("Save", :disable_with => "Saving...", :confirm => "Are you sure?") @@ -421,6 +421,15 @@ class FormTagHelperTest < ActionView::TestCase ) end + def test_button_tag_with_disable_with + assert_deprecated ":disable_with option is deprecated and will be removed from Rails 4.0. Use 'data-disable-with' instead" do + assert_dom_equal( + %(), + button_tag("Save", :type => "submit", :disable_with => "Saving...") + ) + end + end + def test_button_tag_with_reset_type assert_dom_equal( %(), -- cgit v1.2.3