From 9514e4e6ad2d52b0a357b4558cddceb110f5e9ab Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Mon, 4 Sep 2006 20:25:43 +0000 Subject: Deprecated the auto-appending of .png to AssetTagHelper#image_tag calls that doesn't have an extension [DHH] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@4999 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- actionpack/test/template/asset_tag_helper_test.rb | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) (limited to 'actionpack/test/template/asset_tag_helper_test.rb') diff --git a/actionpack/test/template/asset_tag_helper_test.rb b/actionpack/test/template/asset_tag_helper_test.rb index d5a8cef94c..bc386a535d 100644 --- a/actionpack/test/template/asset_tag_helper_test.rb +++ b/actionpack/test/template/asset_tag_helper_test.rb @@ -113,11 +113,15 @@ class AssetTagHelperTest < Test::Unit::TestCase end def test_image_path - ImagePathToTag.each { |method, tag| assert_dom_equal(tag, eval(method)) } + ImagePathToTag.each do |method, tag| + assert_deprecated(/image_path/) { assert_dom_equal(tag, eval(method)) } + end end def test_image_tag - ImageLinkToTag.each { |method, tag| assert_dom_equal(tag, eval(method)) } + ImageLinkToTag.each do |method, tag| + assert_deprecated(/image_path/) { assert_dom_equal(tag, eval(method)) } + end end def test_timebased_asset_id @@ -145,13 +149,11 @@ class AssetTagHelperNonVhostTest < Test::Unit::TestCase def setup @controller = Class.new do - attr_accessor :request def url_for(options, *parameters_for_method_reference) "http://www.example.com/calloboration/hieraki" end - end.new @request = Class.new do @@ -198,7 +200,6 @@ class AssetTagHelperNonVhostTest < Test::Unit::TestCase %(image_tag("xml")) => %(Xml), %(image_tag("rss", :alt => "rss syndication")) => %(rss syndication), %(image_tag("gold", :size => "45x70")) => %(Gold), - %(image_tag("http://www.example.com/images/icon.gif")) => %(Icon), %(image_tag("symbolize", "size" => "45x70")) => %(Symbolize) } @@ -230,11 +231,13 @@ class AssetTagHelperNonVhostTest < Test::Unit::TestCase end def test_image_path - ImagePathToTag.each { |method, tag| assert_dom_equal(tag, eval(method)) } + ImagePathToTag.each { |method, tag| assert_deprecated(/image_path/) { assert_dom_equal(tag, eval(method)) } } end def test_image_tag - ImageLinkToTag.each { |method, tag| assert_dom_equal(tag, eval(method)) } + ImageLinkToTag.each do |method, tag| + assert_deprecated(/image_path/) { assert_dom_equal(tag, eval(method)) } + end # Assigning a default alt tag should not cause an exception to be raised assert_nothing_raised { image_tag('') } end -- cgit v1.2.3