From 38f8872aa5fd8f0a1d0895e9eb41f73261acd040 Mon Sep 17 00:00:00 2001 From: Damien Mathieu <42@dmathieu.com> Date: Wed, 30 Oct 2013 15:04:19 +0100 Subject: session#fetch doesn't behave exactly like Hash#fetch. Mention it in the changelog and add a test checking for regressions. Hash#fetch isn't adding the defaultly returned value. However, in the session, saving it is the behavior we should expect. See discussion in #12692 --- actionpack/test/dispatch/request/session_test.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'actionpack/test/dispatch/request') diff --git a/actionpack/test/dispatch/request/session_test.rb b/actionpack/test/dispatch/request/session_test.rb index 2fed480396..a244d1364c 100644 --- a/actionpack/test/dispatch/request/session_test.rb +++ b/actionpack/test/dispatch/request/session_test.rb @@ -63,11 +63,15 @@ module ActionDispatch def test_fetch session = Session.create(store, {}, {}) - session['one'] = '1' + session['one'] = '1' assert_equal '1', session.fetch(:one) + assert_equal '2', session.fetch(:two, '2') + assert_equal '2', session.fetch(:two) + assert_equal 'three', session.fetch(:three) {|el| el.to_s } + assert_equal 'three', session.fetch(:three) assert_raise KeyError do session.fetch(:four) -- cgit v1.2.3